Re: [PATCH] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

[kernel test robot]

Hi Don,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on a2ea4e1d9091cd8bc69f1c42c15bedc38618f04c]

url:    
https://github.com/0day-ci/linux/commits/Don-Bollinger/eeprom-optoe-driver-to-read-write-SFP-QSFP-CMIS-EEPROMS/20210215-083817
base:   a2ea4e1d9091cd8bc69f1c42c15bedc38618f04c
config: riscv-randconfig-r001-20210215 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 
c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # 
https://github.com/0day-ci/linux/commit/9089aa757bfb70c473ca54face762582908bdd28
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Don-Bollinger/eeprom-optoe-driver-to-read-write-SFP-QSFP-CMIS-EEPROMS/20210215-083817
        git checkout 9089aa757bfb70c473ca54face762582908bdd28
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/misc/eeprom/optoe.c:615:16: warning: no previous prototype for 
>> function 'optoe_make_regmap' [-Wmissing-prototypes]
   struct regmap *optoe_make_regmap(struct i2c_client *client)
                  ^
   drivers/misc/eeprom/optoe.c:615:1: note: declare 'static' if the function is 
not intended to be used outside of this translation unit
   struct regmap *optoe_make_regmap(struct i2c_client *client)
   ^
   static 
   1 warning generated.


vim +/optoe_make_regmap +615 drivers/misc/eeprom/optoe.c

   605  
   606  
   607  /*
   608   * optoe_make_regmap creates the regmap for the client.
   609   * IMPORTANT: Don't call the regmap read/write calls directly
   610   * for these devices.  These devices are paged, and you have to
   611   * set the page register before accessing the data in that page.
   612   * Use the nvmem interfaces, those read/write calls use this
   613   * driver to manage pages correctly.
   614   */
 > 615  struct regmap *optoe_make_regmap(struct i2c_client *client)
   616  {
   617          struct regmap_config regmap_config = { };
   618          struct regmap *regmap;
   619  
   620          /* setup a minimal regmap - 8 bits, 8 bit addresses */
   621          regmap_config.val_bits = 8;
   622          regmap_config.reg_bits = 8;
   623  
   624          /* I'll handle the locking */
   625          regmap_config.disable_locking = true;
   626          regmap = devm_regmap_init_i2c(client, &regmap_config);
   627          return regmap;
   628  }
   629  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

.config.gz
Description: application/gzip