On Tue, Feb 16, 2021 at 07:50:49PM +0000, Min Li wrote: > > > > Yes, that line. > > > > The documentation should tell you how to do that, as per my patch bot: > > > > - This looks like a new version of a previously submitted patch, but you > > did not list below the --- line any changes from the previous version. > > Please read the section entitled "The canonical patch format" in the > > kernel file, Documentation/SubmittingPatches for what needs to be done > > here to properly describe this. > > > > thanks, > > > > greg k-h > > Hi Greg > > I read documentation. Am I supposed to add the "---" marker line manually by > myself when doing "git commit --amend"? git commit will > always add a "---" marker line before the actual change like below > > Signed-off-by: Min Li <[email protected]> > --- > Changes since v1: > -Provide more background for purpose of the change. > -Provide compat_ioctl support > -Fix ioctl cmd definition > --- > drivers/misc/Kconfig | 13 ++ > drivers/misc/Makefile | 3 +
You add the text after you have created the patch with 'git format-patch' by editing the text file before sending it off to us. You don't add it to the changelog comment itself. hope this helps, greg k-h
