On Wed, 17 Feb 2021 14:28:00 +0000,
Marc Zyngier <[email protected]> wrote:
>
> Implementing CONFIG_GENERIC_IRQ_MULTI_HANDLER is a decision that is
> made at the architecture level, and shouldn't involve the irqchip
> at all (we even provide a fallback helper when the option isn't
> selected).
>
> Drop all instances of such selection from non-arch code.
>
> Signed-off-by: Marc Zyngier <[email protected]>
> ---
> drivers/irqchip/Kconfig | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index da7b3cf63b07..1e3dba80ff0b 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
[...]
> @@ -64,7 +62,6 @@ config ARM_NVIC
> config ARM_VIC
> bool
> select IRQ_DOMAIN
> - select GENERIC_IRQ_MULTI_HANDLER
>
Mark pointed out that ep93xx doesn't select GENERIC_IRQ_MULTI_HANDLER,
and that this removal breaks it. I've added the patch below before
this one to address the issue.
Thanks,
M.
>From c14dc142dd97708d53566efafd7ef7c4e8354f8d Mon Sep 17 00:00:00 2001
From: Marc Zyngier <[email protected]>
Date: Wed, 17 Feb 2021 18:10:35 +0000
Subject: [PATCH] ARM: ep93xx: Select GENERIC_IRQ_MULTI_HANDLER directly
ep93xx currently relies of CONFIG_ARM_VIC to select
GENERIC_IRQ_MULTI_HANDLER. Given that this is logically a platform
architecture property, add the selection of GENERIC_IRQ_MULTI_HANDLER
at the platform level.
Further patches will remove the selection from the irqchip side.
Reported-by: Marc Rutland <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
---
arch/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 138248999df7..8efa01363da3 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -348,6 +348,7 @@ config ARCH_EP93XX
select ARM_AMBA
imply ARM_PATCH_PHYS_VIRT
select ARM_VIC
+ select GENERIC_IRQ_MULTI_HANDLER
select AUTO_ZRELADDR
select CLKDEV_LOOKUP
select CLKSRC_MMIO
--
2.30.0
--
Without deviation from the norm, progress is not possible.
