On Tue, Feb 16, 2021 at 04:06:44PM -0500, Nicholas Fraser wrote:
> tests/shell/buildid.sh added an ELF executable with an MD5 build-id to
> the perf debug cache but did not check whether the object was printed
> by a subsequent call to "perf buildid-cache -l". It was being omitted
> from the list.
>
> A previous commit fixed the bug that left it out of the list. This adds
> a test for it.
>
> Signed-off-by: Nicholas Fraser <nfra...@codeweavers.com>
Acked-by: Jiri Olsa <jo...@redhat.com>
few nits below
> ---
> tools/perf/tests/shell/buildid.sh | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tools/perf/tests/shell/buildid.sh
> b/tools/perf/tests/shell/buildid.sh
> index 4861a20edee2..de02a23b7c7b 100755
> --- a/tools/perf/tests/shell/buildid.sh
> +++ b/tools/perf/tests/shell/buildid.sh
> @@ -50,6 +50,12 @@ check()
> exit 1
> fi
>
> + ${perf} buildid-cache -l|grep $id
please make space before and after '|'
and use ${id} instead of $id, we use that all over the script
thanks,
jirka
> + if [ $? -ne 0 ]; then
> + echo "failed: ${id} is not reported by \"perf buildid-cache
> -l\""
> + exit 1
> + fi
> +
> echo "OK for ${1}"
> }
>
> --
> 2.30.1
>
