On Tue, 8 Jan 2008 14:51:37 +0100 DM <[EMAIL PROTECTED]> wrote: > On Jan 7, 2008 12:19 AM, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > [...] > > This patch tracks the last unloaded module, and prints this as part > > of the module list in the oops trace. > > > [...] > > } > > + /* Store the name of the last unloaded module for > > diagnostic purposes */ > > + sprintf(last_unloaded_module, mod->name); > > free_module(mod); > > > > Why use sprintf? If a module name contains the % character we could > overflow the buffer. Or is module-unloading root-only and we don't > care?
module loading isn't just root only; the name comes from an already loaded module. If you can load kernel modules of your choice you own the entire kernel already anway -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
