On Tue, 23 Feb 2021 14:11:24 +0100 Jens Wiklander <jens.wiklan...@linaro.org> wrote:
> I used the -strict option. > > ./scripts/checkpatch.pl -strict 0001-tee-optee-add-invoke_fn-tracepoints.patch > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #44: > new file mode 100644 The above is just asking for someone to take maintainership of the new file. > > CHECK: Alignment should match open parenthesis > #68: FILE: drivers/tee/optee/optee_trace.h:20: > +TRACE_EVENT(optee_invoke_fn_begin, > + TP_PROTO(struct optee_rpc_param *param), > > CHECK: Lines should not end with a '(' > #71: FILE: drivers/tee/optee/optee_trace.h:23: > + TP_STRUCT__entry( > > CHECK: Lines should not end with a '(' > #76: FILE: drivers/tee/optee/optee_trace.h:28: > + TP_fast_assign( > > CHECK: Alignment should match open parenthesis > #89: FILE: drivers/tee/optee/optee_trace.h:41: > +TRACE_EVENT(optee_invoke_fn_end, > + TP_PROTO(struct optee_rpc_param *param, struct arm_smccc_res *res), > > CHECK: Lines should not end with a '(' > #92: FILE: drivers/tee/optee/optee_trace.h:44: > + TP_STRUCT__entry( > > CHECK: Lines should not end with a '(' > #97: FILE: drivers/tee/optee/optee_trace.h:49: > + TP_fast_assign( The TRACE_EVENT() macro is "special", and checkpatch notoriously stumbles over it. I usually recommend that people ignore the checkpatch warnings on TRACE_EVENT() macros. -- Steve > > total: 0 errors, 1 warnings, 6 checks, 86 lines checked