On Tue, Feb 23, 2021 at 04:08:52PM +0100, Christoph Hellwig wrote: > On Tue, Feb 23, 2021 at 07:37:52AM +0000, Chaitanya Kulkarni wrote: > > On 2/22/21 23:10, Christoph Hellwig wrote: > > > On Tue, Feb 23, 2021 at 03:51:23AM +0000, Chaitanya Kulkarni wrote: > > >> Looking at the other call sites do we need something like following ? > > >> Since __blk_queue_bounce() passes the NULL for the passthru case as a > > >> bio_set value ? > > > Well, that is a somewhat odd calling convention. What about the patch > > > below > > > instead? That being we really need to kill this bouncing code off.. > > I assume you are sending this patch, let me know otherwise. > > If you do please add, looks good. > > I'll split the gfp_mask cleanup out, and will submit it with your as > the author if that is ok. I'll need a signoff, though.
Actually, I ended up reworking it once more as there is no point for the parameter either.
