Hi Jianjun,
[...]
> +static struct irq_chip mtk_msi_irq_chip = {
> + .name = "MSI",
> + .irq_enable = mtk_pcie_irq_unmask,
> + .irq_disable = mtk_pcie_irq_mask,
> + .irq_ack = irq_chip_ack_parent,
> + .irq_mask = mtk_pcie_irq_mask,
> + .irq_unmask = mtk_pcie_irq_unmask,
> +};
For consistency sake, what about aligning this like the
struct mtk_msi_bottom_irq_chip has been? See immediately below.
[...]
> +static struct irq_chip mtk_msi_bottom_irq_chip = {
> + .irq_ack = mtk_msi_bottom_irq_ack,
> + .irq_mask = mtk_msi_bottom_irq_mask,
> + .irq_unmask = mtk_msi_bottom_irq_unmask,
> + .irq_compose_msi_msg = mtk_compose_msi_msg,
> + .irq_set_affinity = mtk_pcie_set_affinity,
> + .name = "MSI",
> +};
Krzysztof
