Hi Suzuki,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on next-20210226]
[cannot apply to kvmarm/next arm64/for-next/core tip/perf/core v5.11]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Suzuki-K-Poulose/arm64-coresight-Add-support-for-ETE-and-TRBE/20210226-035447
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
6fbd6cf85a3be127454a1ad58525a3adcf8612ab
config: arm-randconfig-r024-20210225 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 
a921aaf789912d981cbb2036bdc91ad7289e1523)
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # 
https://github.com/0day-ci/linux/commit/c37564326cdf11e0839eae06c1bfead47d3e5775
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Suzuki-K-Poulose/arm64-coresight-Add-support-for-ETE-and-TRBE/20210226-035447
        git checkout c37564326cdf11e0839eae06c1bfead47d3e5775
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All errors (new ones prefixed by >>):

>> drivers/hwtracing/coresight/coresight-core.c:800:6: error: implicit 
>> declaration of function 'coresight_is_percpu_source' 
>> [-Werror,-Wimplicit-function-declaration]
           if (coresight_is_percpu_source(csdev) && 
coresight_is_percpu_sink(sink) &&
               ^
>> drivers/hwtracing/coresight/coresight-core.c:800:43: error: implicit 
>> declaration of function 'coresight_is_percpu_sink' 
>> [-Werror,-Wimplicit-function-declaration]
           if (coresight_is_percpu_source(csdev) && 
coresight_is_percpu_sink(sink) &&
                                                    ^
   drivers/hwtracing/coresight/coresight-core.c:1024:7: error: implicit 
declaration of function 'coresight_is_percpu_source' 
[-Werror,-Wimplicit-function-declaration]
                   if (coresight_is_percpu_source(csdev))
                       ^
   3 errors generated.


vim +/coresight_is_percpu_source +800 
drivers/hwtracing/coresight/coresight-core.c

   775  
   776  /**
   777   * _coresight_build_path - recursively build a path from a @csdev to a 
sink.
   778   * @csdev:      The device to start from.
   779   * @sink:       The final sink we want in this path.
   780   * @path:       The list to add devices to.
   781   *
   782   * The tree of Coresight device is traversed until an activated sink is
   783   * found.  From there the sink is added to the list along with all the
   784   * devices that led to that point - the end result is a list from source
   785   * to sink. In that list the source is the first device and the sink the
   786   * last one.
   787   */
   788  static int _coresight_build_path(struct coresight_device *csdev,
   789                                   struct coresight_device *sink,
   790                                   struct list_head *path)
   791  {
   792          int i, ret;
   793          bool found = false;
   794          struct coresight_node *node;
   795  
   796          /* An activated sink has been found.  Enqueue the element */
   797          if (csdev == sink)
   798                  goto out;
   799  
 > 800          if (coresight_is_percpu_source(csdev) && 
 > coresight_is_percpu_sink(sink) &&
   801              sink == per_cpu(csdev_sink, 
source_ops(csdev)->cpu_id(csdev))) {
   802                  if (_coresight_build_path(sink, sink, path) == 0) {
   803                          found = true;
   804                          goto out;
   805                  }
   806          }
   807  
   808          /* Not a sink - recursively explore each port found on this 
element */
   809          for (i = 0; i < csdev->pdata->nr_outport; i++) {
   810                  struct coresight_device *child_dev;
   811  
   812                  child_dev = csdev->pdata->conns[i].child_dev;
   813                  if (child_dev &&
   814                      _coresight_build_path(child_dev, sink, path) == 0) {
   815                          found = true;
   816                          break;
   817                  }
   818          }
   819  
   820          if (!found)
   821                  return -ENODEV;
   822  
   823  out:
   824          /*
   825           * A path from this element to a sink has been found.  The 
elements
   826           * leading to the sink are already enqueued, all that is left 
to do
   827           * is tell the PM runtime core we need this element and add a 
node
   828           * for it.
   829           */
   830          ret = coresight_grab_device(csdev);
   831          if (ret)
   832                  return ret;
   833  
   834          node = kzalloc(sizeof(struct coresight_node), GFP_KERNEL);
   835          if (!node)
   836                  return -ENOMEM;
   837  
   838          node->csdev = csdev;
   839          list_add(&node->link, path);
   840  
   841          return 0;
   842  }
   843  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to