> On Feb 26, 2021, at 10:29 AM, Maciej Kwapulinski
> <maciej.kwapulin...@linux.intel.com> wrote:
>
>
> Andy Shevchenko <andy.shevche...@gmail.com> writes:
>
>> On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski
>> <maciej.kwapulin...@linux.intel.com> wrote:
>>>
> ....
>>> +#define GNA_DRV_VER "1.2.0"
>>
>> Nowadays the version is the Git SHA sum.
>>
>
> right, "version" is present in about 7% of all modules
>
> do You mean version should be skipped over (automatically generated)
> srcversion field? or maybe You suggest any (better) technique?
Just my 0.02. We should identify who will consume this version string for what
purposes. Then we can decide if a hardcoded macro or any auto-gen tags should
be used. If we don’t find such need, perhaps we just remove it since a snapshot
of the code is always tagged by commit SHA1 in git. (maybe this is what Andy
suggested?).
Having such hardcoded version string requires an update policy in return, to
make it really useful, IMO.
