From: Pan Bian <bianpan2...@163.com>

commit fe6653460ee7a7dbe0cd5fd322992af862ce5ab0 upstream.

Put the child node np when it fails to get or register device.

Fixes: e523f11141bd ("mtd: spi-nor: add hisilicon spi-nor flash controller 
driver")
Cc: sta...@vger.kernel.org
Signed-off-by: Pan Bian <bianpan2...@163.com>
[ta: Add Fixes tag and Cc stable]
Signed-off-by: Tudor Ambarus <tudor.amba...@microchip.com>
Link: https://lore.kernel.org/r/20210121091847.85362-1-bianpan2...@163.com
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
 drivers/mtd/spi-nor/hisi-sfc.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- a/drivers/mtd/spi-nor/hisi-sfc.c
+++ b/drivers/mtd/spi-nor/hisi-sfc.c
@@ -393,8 +393,10 @@ static int hisi_spi_nor_register_all(str
 
        for_each_available_child_of_node(dev->of_node, np) {
                ret = hisi_spi_nor_register(np, host);
-               if (ret)
+               if (ret) {
+                       of_node_put(np);
                        goto fail;
+               }
 
                if (host->num_chip == HIFMC_MAX_CHIP_NUM) {
                        dev_warn(dev, "Flash device number exceeds the maximum 
chipselect number\n");


Reply via email to