From: Pan Bian <bianpan2...@163.com>

[ Upstream commit 0f7b4bc6bb1e57c48ef14f1818df947c1612b206 ]

Free the request rq before returning error code.

Fixes: 972248e9111e ("scsi: bsg-lib: handle bidi requests without block layer 
help")
Signed-off-by: Pan Bian <bianpan2...@163.com>
Reviewed-by: Christoph Hellwig <h...@lst.de>
Signed-off-by: Jens Axboe <ax...@kernel.dk>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 block/bsg.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/block/bsg.c b/block/bsg.c
index d7bae94b64d95..3d78e843a83f6 100644
--- a/block/bsg.c
+++ b/block/bsg.c
@@ -157,8 +157,10 @@ static int bsg_sg_io(struct request_queue *q, fmode_t 
mode, void __user *uarg)
                return PTR_ERR(rq);
 
        ret = q->bsg_dev.ops->fill_hdr(rq, &hdr, mode);
-       if (ret)
+       if (ret) {
+               blk_put_request(rq);
                return ret;
+       }
 
        rq->timeout = msecs_to_jiffies(hdr.timeout);
        if (!rq->timeout)
-- 
2.27.0



Reply via email to