From: Alexander Usyskin <alexander.usys...@intel.com> commit 740c0a57b8f1e36301218bf549f3c9cc833a60be upstream.
The MEI bus has a special behavior on suspend it destroys all the attached devices, this is due to the fact that also firmware context is not persistent across power flows. If watchdog on MEI bus is ticking before suspending the firmware times out and reports that the OS is missing watchdog tick. Send the stop command to the firmware on watchdog unregistered to eliminate the false event on suspend. This does not make the things worse from the user-space perspective as a user-space should re-open watchdog device after suspending before this patch. Cc: <sta...@vger.kernel.org> Signed-off-by: Alexander Usyskin <alexander.usys...@intel.com> Signed-off-by: Tomas Winkler <tomas.wink...@intel.com> Reviewed-by: Guenter Roeck <li...@roeck-us.net> Link: https://lore.kernel.org/r/20210124114938.373885-1-tomas.wink...@intel.com Signed-off-by: Guenter Roeck <li...@roeck-us.net> Signed-off-by: Wim Van Sebroeck <w...@linux-watchdog.org> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/watchdog/mei_wdt.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/watchdog/mei_wdt.c +++ b/drivers/watchdog/mei_wdt.c @@ -382,6 +382,7 @@ static int mei_wdt_register(struct mei_w watchdog_set_drvdata(&wdt->wdd, wdt); watchdog_stop_on_reboot(&wdt->wdd); + watchdog_stop_on_unregister(&wdt->wdd); ret = watchdog_register_device(&wdt->wdd); if (ret)
