On Wed, 03 Mar 2021, Alexandre Belloni wrote: > On 03/03/2021 12:41:49+0000, Lee Jones wrote: > > Both the caller and the supplier's source file should have access to > > the include file containing the prototypes. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/pinctrl/pinctrl-at91.c:1637:6: warning: no previous prototype for > > ‘at91_pinctrl_gpio_suspend’ [-Wmissing-prototypes] > > 1637 | void at91_pinctrl_gpio_suspend(void) > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > drivers/pinctrl/pinctrl-at91.c:1661:6: warning: no previous prototype for > > ‘at91_pinctrl_gpio_resume’ [-Wmissing-prototypes] > > 1661 | void at91_pinctrl_gpio_resume(void) > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > > Cc: Russell King <[email protected]> > > Cc: Nicolas Ferre <[email protected]> > > Cc: Alexandre Belloni <[email protected]> > > Cc: Ludovic Desroches <[email protected]> > > Signed-off-by: Lee Jones <[email protected]> > > I'm pretty sure you had my ack on v3 ;) > > Acked-by: Alexandre Belloni <[email protected]> > > or again, alternatively, I can apply it with Linus' ack
That would be my preference, thanks. > > --- > > arch/arm/mach-at91/pm.c | 19 ++++++++----------- > > drivers/pinctrl/pinctrl-at91.c | 2 ++ > > include/soc/at91/pm.h | 16 ++++++++++++++++ > > 3 files changed, 26 insertions(+), 11 deletions(-) > > create mode 100644 include/soc/at91/pm.h -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
