Update PCIe + USB register sequences for correct PLL1 clock configuration.
Also, update sequences for other USB configurations with dependent changes.

Signed-off-by: Swapnil Jakhade <sjakh...@cadence.com>
Signed-off-by: Kishon Vijay Abraham I <kis...@ti.com>
---
 drivers/phy/cadence/phy-cadence-torrent.c | 47 +++++++++++++++--------
 1 file changed, 31 insertions(+), 16 deletions(-)

diff --git a/drivers/phy/cadence/phy-cadence-torrent.c 
b/drivers/phy/cadence/phy-cadence-torrent.c
index f78a6731c26a..b371795e66a2 100644
--- a/drivers/phy/cadence/phy-cadence-torrent.c
+++ b/drivers/phy/cadence/phy-cadence-torrent.c
@@ -2655,8 +2655,6 @@ static struct cdns_reg_pairs usb_100_int_ssc_cmn_regs[] = 
{
        {0x0C5E, CMN_PLL1_VCOCAL_REFTIM_START},
        {0x0C56, CMN_PLL0_VCOCAL_PLLCNT_START},
        {0x0C56, CMN_PLL1_VCOCAL_PLLCNT_START},
-       {0x0003, CMN_PLL0_VCOCAL_TCTRL},
-       {0x0003, CMN_PLL1_VCOCAL_TCTRL},
        {0x00C7, CMN_PLL0_LOCK_REFCNT_START},
        {0x00C7, CMN_PLL1_LOCK_REFCNT_START},
        {0x00C7, CMN_PLL0_LOCK_PLLCNT_START},
@@ -2664,7 +2662,9 @@ static struct cdns_reg_pairs usb_100_int_ssc_cmn_regs[] = 
{
        {0x0005, CMN_PLL0_LOCK_PLLCNT_THR},
        {0x0005, CMN_PLL1_LOCK_PLLCNT_THR},
        {0x8200, CMN_CDIAG_CDB_PWRI_OVRD},
-       {0x8200, CMN_CDIAG_XCVRC_PWRI_OVRD}
+       {0x8200, CMN_CDIAG_XCVRC_PWRI_OVRD},
+       {0x007F, CMN_TXPUCAL_TUNE},
+       {0x007F, CMN_TXPDCAL_TUNE}
 };
 
 static struct cdns_torrent_vals usb_100_int_ssc_cmn_vals = {
@@ -2707,13 +2707,28 @@ static struct cdns_torrent_vals usb_phy_pcs_cmn_vals = {
 };
 
 /* USB 100 MHz Ref clk, no SSC */
-static struct cdns_reg_pairs usb_100_no_ssc_cmn_regs[] = {
+static struct cdns_reg_pairs sl_usb_100_no_ssc_cmn_regs[] = {
+       {0x0028, CMN_PDIAG_PLL1_CP_PADJ_M0},
+       {0x001E, CMN_PLL1_DSM_FBH_OVRD_M0},
+       {0x000C, CMN_PLL1_DSM_FBL_OVRD_M0},
        {0x0003, CMN_PLL0_VCOCAL_TCTRL},
        {0x0003, CMN_PLL1_VCOCAL_TCTRL},
        {0x8200, CMN_CDIAG_CDB_PWRI_OVRD},
        {0x8200, CMN_CDIAG_XCVRC_PWRI_OVRD}
 };
 
+static struct cdns_torrent_vals sl_usb_100_no_ssc_cmn_vals = {
+       .reg_pairs = sl_usb_100_no_ssc_cmn_regs,
+       .num_regs = ARRAY_SIZE(sl_usb_100_no_ssc_cmn_regs),
+};
+
+static struct cdns_reg_pairs usb_100_no_ssc_cmn_regs[] = {
+       {0x8200, CMN_CDIAG_CDB_PWRI_OVRD},
+       {0x8200, CMN_CDIAG_XCVRC_PWRI_OVRD},
+       {0x007F, CMN_TXPUCAL_TUNE},
+       {0x007F, CMN_TXPDCAL_TUNE}
+};
+
 static struct cdns_reg_pairs usb_100_no_ssc_tx_ln_regs[] = {
        {0x02FF, TX_PSC_A0},
        {0x06AF, TX_PSC_A1},
@@ -3497,8 +3512,8 @@ static const struct cdns_torrent_data cdns_map_torrent = {
                },
                [TYPE_USB] = {
                        [TYPE_NONE] = {
-                               [NO_SSC] = &usb_100_no_ssc_cmn_vals,
-                               [EXTERNAL_SSC] = &usb_100_no_ssc_cmn_vals,
+                               [NO_SSC] = &sl_usb_100_no_ssc_cmn_vals,
+                               [EXTERNAL_SSC] = &sl_usb_100_no_ssc_cmn_vals,
                                [INTERNAL_SSC] = &sl_usb_100_int_ssc_cmn_vals,
                        },
                        [TYPE_PCIE] = {
@@ -3507,13 +3522,13 @@ static const struct cdns_torrent_data cdns_map_torrent 
= {
                                [INTERNAL_SSC] = &usb_100_int_ssc_cmn_vals,
                        },
                        [TYPE_SGMII] = {
-                               [NO_SSC] = &usb_100_no_ssc_cmn_vals,
-                               [EXTERNAL_SSC] = &usb_100_no_ssc_cmn_vals,
+                               [NO_SSC] = &sl_usb_100_no_ssc_cmn_vals,
+                               [EXTERNAL_SSC] = &sl_usb_100_no_ssc_cmn_vals,
                                [INTERNAL_SSC] = &sl_usb_100_int_ssc_cmn_vals,
                        },
                        [TYPE_QSGMII] = {
-                               [NO_SSC] = &usb_100_no_ssc_cmn_vals,
-                               [EXTERNAL_SSC] = &usb_100_no_ssc_cmn_vals,
+                               [NO_SSC] = &sl_usb_100_no_ssc_cmn_vals,
+                               [EXTERNAL_SSC] = &sl_usb_100_no_ssc_cmn_vals,
                                [INTERNAL_SSC] = &sl_usb_100_int_ssc_cmn_vals,
                        },
                },
@@ -3906,8 +3921,8 @@ static const struct cdns_torrent_data 
ti_j721e_map_torrent = {
                },
                [TYPE_USB] = {
                        [TYPE_NONE] = {
-                               [NO_SSC] = &usb_100_no_ssc_cmn_vals,
-                               [EXTERNAL_SSC] = &usb_100_no_ssc_cmn_vals,
+                               [NO_SSC] = &sl_usb_100_no_ssc_cmn_vals,
+                               [EXTERNAL_SSC] = &sl_usb_100_no_ssc_cmn_vals,
                                [INTERNAL_SSC] = &sl_usb_100_int_ssc_cmn_vals,
                        },
                        [TYPE_PCIE] = {
@@ -3916,13 +3931,13 @@ static const struct cdns_torrent_data 
ti_j721e_map_torrent = {
                                [INTERNAL_SSC] = &usb_100_int_ssc_cmn_vals,
                        },
                        [TYPE_SGMII] = {
-                               [NO_SSC] = &usb_100_no_ssc_cmn_vals,
-                               [EXTERNAL_SSC] = &usb_100_no_ssc_cmn_vals,
+                               [NO_SSC] = &sl_usb_100_no_ssc_cmn_vals,
+                               [EXTERNAL_SSC] = &sl_usb_100_no_ssc_cmn_vals,
                                [INTERNAL_SSC] = &sl_usb_100_int_ssc_cmn_vals,
                        },
                        [TYPE_QSGMII] = {
-                               [NO_SSC] = &usb_100_no_ssc_cmn_vals,
-                               [EXTERNAL_SSC] = &usb_100_no_ssc_cmn_vals,
+                               [NO_SSC] = &sl_usb_100_no_ssc_cmn_vals,
+                               [EXTERNAL_SSC] = &sl_usb_100_no_ssc_cmn_vals,
                                [INTERNAL_SSC] = &sl_usb_100_int_ssc_cmn_vals,
                        },
                },
-- 
2.26.1

Reply via email to