Hi Masami, I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v5.12-rc1 next-20210304] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Masami-Hiramatsu/kprobes-stacktrace-Recover-the-address-changed-by-kretprobe/20210304-212528 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f69d02e37a85645aa90d18cacfff36dba370f797 config: x86_64-randconfig-m001-20210304 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/2204ff150821a6a3c13b4fa10784b5efb3e3adc8 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Masami-Hiramatsu/kprobes-stacktrace-Recover-the-address-changed-by-kretprobe/20210304-212528 git checkout 2204ff150821a6a3c13b4fa10784b5efb3e3adc8 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): kernel/stacktrace.c: In function 'stack_trace_consume_entry': >> kernel/stacktrace.c:97:9: error: implicit declaration of function >> 'kretprobe_real_stack_tsk' [-Werror=implicit-function-declaration] 97 | addr = kretprobe_real_stack_tsk(c->tsk, addr, &c->cur); | ^~~~~~~~~~~~~~~~~~~~~~~~ >> kernel/stacktrace.c:97:35: error: 'struct stacktrace_cookie' has no member >> named 'tsk' 97 | addr = kretprobe_real_stack_tsk(c->tsk, addr, &c->cur); | ^~ >> kernel/stacktrace.c:97:50: error: 'struct stacktrace_cookie' has no member >> named 'cur' 97 | addr = kretprobe_real_stack_tsk(c->tsk, addr, &c->cur); | ^~ cc1: some warnings being treated as errors vim +/kretprobe_real_stack_tsk +97 kernel/stacktrace.c 85 86 static bool stack_trace_consume_entry(void *cookie, unsigned long addr) 87 { 88 struct stacktrace_cookie *c = cookie; 89 90 if (c->len >= c->size) 91 return false; 92 93 if (c->skip > 0) { 94 c->skip--; 95 return true; 96 } > 97 addr = kretprobe_real_stack_tsk(c->tsk, addr, &c->cur); 98 c->store[c->len++] = addr; 99 return c->len < c->size; 100 } 101 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
