On Fri, 11 Jan 2008 03:38:42 +0300 Anton Salikhmetov <[EMAIL PROTECTED]> wrote:
> @@ -33,71 +34,60 @@ asmlinkage long sys_msync(unsigned long start, size_t > len, int flags) > unsigned long end; > struct mm_struct *mm = current->mm; > struct vm_area_struct *vma; > - int unmapped_error = 0; > - int error = -EINVAL; > + int error = 0, unmapped_error = 0; > + > + if ((flags & ~(MS_ASYNC | MS_INVALIDATE | MS_SYNC)) || > + (start & ~PAGE_MASK) || > + ((flags & MS_ASYNC) && (flags & MS_SYNC))) > + return -EINVAL; > > - if (flags & ~(MS_ASYNC | MS_INVALIDATE | MS_SYNC)) > - goto out; > - if (start & ~PAGE_MASK) > - goto out; > - if ((flags & MS_ASYNC) && (flags & MS_SYNC)) > - goto out; > - error = -ENOMEM; Personally I prefer having these error checks separated out, but that's just my opinion :) I like the rest of your cleanup patch. -- All rights reversed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
