On Fri, Mar 05, 2021 at 05:34:33PM +0000, Lucas Tanure wrote:

> -     /* Hold down reset */
> -     gpiod_set_value_cansleep(cs42l42->reset_gpio, 0);
> +     disable_irq(i2c_client->irq);
> +     pm_runtime_suspend(&i2c_client->dev);
> +     pm_runtime_disable(&i2c_client->dev);

You should be unregistering the interrupt, not disabling it - this will
better support any shared IRQ usage that appears and is much, much more
idiomatic.

Attachment: signature.asc
Description: PGP signature

Reply via email to