On Sat, Mar 06, 2021 at 01:28:22AM +0900, Masahiro Yamada wrote: > > +orig_name := $(if $(CONFIG_CC_IS_GCC),GCC,CLANG) > > +orig_minor := $(shell expr $(if > > $(CONFIG_CC_IS_GCC),$(CONFIG_GCC_VERSION),$(CONFIG_CLANG_VERSION)) / 100) > > +cur_namever := $(shell $(srctree)/scripts/cc-version.sh $(CC)) > > +cur_name := $(word 1,$(cur_namever)) > > +cur_minor := $(shell expr $(word 2,$(cur_namever)) / 100) > > These are still calculated by 'make M=... clean' or 'make M=... help'. > Using '=' assignment solves it, but the code is still ugly. > > > I attached my alternative implementation.
Thanks for the attached patch, yours looks much cleaner. Looks like it warns on *any* mismatch, rather than just a major.minor mismatch. But that's ok with me. Acked-by: Josh Poimboeuf <jpoim...@redhat.com> -- Josh
