Re: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller

[Dmitry Torokhov]

Hi Oleksij,

On Fri, Mar 05, 2021 at 02:38:13PM +0100, Oleksij Rempel wrote:
> +
> +     /* TODO: remove IRQ_NOAUTOEN after needed patches are mainline */
> +     irq_set_status_flags(spi->irq, IRQ_NOAUTOEN);
> +     ret = devm_request_threaded_irq(dev, spi->irq,
> +                                     NULL,
> +                                     &tsc2046_adc_irq,
> +                                     IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> +                                     name, indio_dev);

I'd recommend dropping IRQF_TRIGGER_LOW and only using IRQF_ONESHOT and
rely on the platform (ACPI, DT) to specify trigger polarity according to
how device is wired in a given system. In general I believe newer
drivers should not specify interrupt triggers themselves.

Thanks.

-- 
Dmitry