Thanks, Alexey for review, i'll make it updated tomorrow. (sorry for top-post)
On 1/14/08, Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > On Sun, Jan 13, 2008 at 11:32:23PM +0300, Cyrill Gorcunov wrote: > > This patch converts ioctl call to unlocked_ioctl form with > > explicit big-kernel-lock. Also it makes a bit of cleanup > > converting miscdevice structure initialization to C99 form. > > > > Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> > > --- > > > > Any comments are welcome. > > This is untested code - i've no such chip on my laptop. > > > > Andi, i think we could use mutex to eliminate BKL, but not sure. > > Looks like it can be dropped here. All usage of rtc-> is done under > rtc_lock. Every other variable there is thread-local. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
