On 03/10, Eric W. Biederman wrote: > > Jim Newsome <[email protected]> writes: > > > +static int do_wait_pid(struct wait_opts *wo) > > +{ > > + struct task_struct *target = pid_task(wo->wo_pid, PIDTYPE_PID); > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > This is subtle change in behavior. > > Today on the task->children list we only place thread group leaders.
Aaah, yes, thanks Eric! > So the code either needs a thread_group_leader filter on target before > the ptrace=0 case or we need to use "pid_task(wo->wo_pid, PIDTYPE_TGID)" > and "pid_task(wo->wo_pid, PIDTYPE_PID)" for the "ptrace=1" case. Agreed, > I would like to make thread_group_leaders go away Hmm, why? Oleg.
