Mel Gorman wrote:
> On (13/01/08 10:34), [EMAIL PROTECTED] didst pronounce:
...
>> int update_end_of_memory(unsigned long end) {return -1;}
>> @@ -343,7 +346,8 @@ int __init acpi_scan_nodes(unsigned long
>> /* First clean up the node list */
>> for (i = 0; i < MAX_NUMNODES; i++) {
>> cutoff_node(i, start, end);
>> - if ((nodes[i].end - nodes[i].start) < NODE_MIN_SIZE) {
>> + /* ZZZ why was this needed. At least add a comment */
>> + if (nodes[i].end && (nodes[i].end - nodes[i].start) <
>> NODE_MIN_SIZE) {
>
> Care to actually add a comment? This looks like a note to yourself that
> got missed.
Oops, sorry, missed this the first time.
Actually that was a note from someone else and I didn't address it.
(Weirdly, I had removed it but some quilt refresh demon brought it back. ;-)
We found this error in testing with a virtual BIOS but I think we
never figured out if it was an error in our BIOS or a valid error.
But in any case, I'll fix it.
Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/