On Sat, Mar 13, 2021 at 11:42:58AM +0100, Andreas Kemnade wrote: > Add the version of the EC in the Tolino Shine 2 HD > to the supported versions. It seems not to have an RTC > and does not ack data written to it. > The vendor kernel happily ignores write errors, using > I2C via userspace i2c-set also shows the error. > So add a quirk to ignore that error. > > PWM can be successfully configured despite of that error. > > Signed-off-by: Andreas Kemnade <[email protected]> > Reviewed-by: Jonathan Neuschäfer <[email protected]> > --- [...] > +static const struct mfd_cell ntxec_subdev_no_rtc[] = { > + { .name = "ntxec-pwm" }, > +};
I left a comment/question about 'no_rtc' vs. 'pwm' in the other thread. > - res = devm_mfd_add_devices(ec->dev, PLATFORM_DEVID_NONE, > ntxec_subdevices, > - ARRAY_SIZE(ntxec_subdevices), NULL, 0, NULL); > + res = devm_mfd_add_devices(ec->dev, PLATFORM_DEVID_NONE, > + subdevs, n_subdevs, > + NULL, 0, NULL); The last two lines might as well be one, width-wise. This version of the patch looks nice and short :) Jonathan
signature.asc
Description: PGP signature
