From: Vladimir Oltean <vladimir.olt...@nxp.com>
Date: Sun, 14 Mar 2021 20:44:49 +0000
> On Sun, Mar 14, 2021 at 09:21:40PM +0100, Jakub Sitnicki wrote:
>> On Fri, Mar 12, 2021 at 09:08 PM CET, Alexander Lobakin wrote:
>>
>> Smells like a breaking change for existing consumers of this value.
>>
>> How about we change the type of flow_dissector_key_icmp{}.id to __be16
>> instead to make sparse happy?
>
> The struct flow_dissector_key_icmp::id only appears to be used in
> bond_xmit_hash, and there, the exact value doesn't seem to matter.
>
> This appears to be a real bug and not just to appease sparse:
> ih->un.echo.id has one endianness and "1" has another. Both cannot
> be correct.
Agreed, so I will apply this, thanks.
