> -----Original Message----- > From: Kishon Vijay Abraham I <[email protected]> > Sent: Wednesday, March 10, 2021 9:16 PM > To: Kishon Vijay Abraham I <[email protected]>; Vinod Koul > <[email protected]>; Rob Herring <[email protected]>; Philipp Zabel > <[email protected]>; Swapnil Kashinath Jakhade > <[email protected]> > Cc: [email protected]; [email protected]; Lokesh Vutla > <[email protected]> > Subject: [PATCH v6 03/13] phy: cadence: cadence-sierra: Create PHY only for > "phy" or "link" sub-nodes > Nitpick, subject line in all Sierra patches in the series could be uniform. Maybe, phy: cadence: Sierra as per earlier commits. Reviewed-by: Swapnil Jakhade <[email protected]> Thanks & regards, Swapnil > EXTERNAL MAIL > > > Cadence Sierra PHY driver registers PHY using devm_phy_create() > for all sub-nodes of Sierra device tree node. However Sierra device > tree node can have sub-nodes for the various clocks in addtion to the > PHY. Use devm_phy_create() only for nodes with name "phy" (or "link" > for old device tree) which represent the actual PHY. > > Signed-off-by: Kishon Vijay Abraham I <[email protected]> > --- > drivers/phy/cadence/phy-cadence-sierra.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/phy/cadence/phy-cadence-sierra.c > b/drivers/phy/cadence/phy-cadence-sierra.c > index 19f32ae877b9..f7ba0ed416bc 100644 > --- a/drivers/phy/cadence/phy-cadence-sierra.c > +++ b/drivers/phy/cadence/phy-cadence-sierra.c > @@ -577,6 +577,10 @@ static int cdns_sierra_phy_probe(struct > platform_device *pdev) > for_each_available_child_of_node(dn, child) { > struct phy *gphy; > > + if (!(of_node_name_eq(child, "phy") || > + of_node_name_eq(child, "link"))) > + continue; > + > sp->phys[node].lnk_rst = > of_reset_control_array_get_exclusive(child); > > -- > 2.17.1
