* Hiroshi Shimamoto <[EMAIL PROTECTED]> wrote:
> From: Hiroshi Shimamoto <[EMAIL PROTECTED]>
> Subject: [PATCH] x86: move warning message of polling idle and HT enabled
>
> This warning at idle_setup() is never shown because smp_num_sibling hasn't
> been updated at this point yet.
>
> Move this polling idle and HT enabled warning message to
> select_idle_routine(). I also implement this warning on 64-bit kernel
> and make select_idle_routine() call after detect_ht() call.
looks good to me, but could you please split this up into two patches
instead - one that just moves/adds the printks, the other one that moves
the select_idle_routine() call? (Moving init calls around is notoriously
error-prone, so we want as small of a bisection target as possible.)
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
