On 15/01/2008, Paul Mundt <[EMAIL PROTECTED]> wrote:
> On Mon, Jan 14, 2008 at 11:17:15PM +0000, Adrian McMenamin wrote:
>
> > +static bool gdrom_data_request(void)
> > +{
> > + return (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) == 8;
> > +}
> > +
> Andrew first pointed this out, and this is still broken.
>
Eh, no, he didn't. What is wrong with it?
He compalined about excessively long busy waiting and then not
checking if the busy wait failed. Both those have been fixed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/