On Wed, Mar 10, 2021 at 10:54:57AM +0530, Bhupesh Sharma wrote: > Newer qcom chips support newer versions of the qce IP, so add > new compatible strings for qcom-qce (in addition to the existing > "qcom,crypto-v5.1"). > > With [1], Thara tried to add the support for new compatible strings, > but we couldn't conclude on the approach to be used. Since we have > a number of new qcom arm64 SoCs available now, several of which > support the same crypto IP version, so it makes more sense to use > the IP version for the compatible string, rather than using the soc > name as the compatible string. > > [1]. > https://lore.kernel.org/linux-arm-msm/20201119155233.3974286-7-thara.gopin...@linaro.org/ > > Cc: Thara Gopinath <thara.gopin...@linaro.org> > Cc: Bjorn Andersson <bjorn.anders...@linaro.org> > Cc: Rob Herring <robh...@kernel.org> > Cc: Andy Gross <agr...@kernel.org> > Cc: Herbert Xu <herb...@gondor.apana.org.au> > Cc: David S. Miller <da...@davemloft.net> > Cc: Stephen Boyd <sb...@kernel.org> > Cc: Michael Turquette <mturque...@baylibre.com> > Cc: linux-...@vger.kernel.org > Cc: linux-cry...@vger.kernel.org > Cc: devicet...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: bhupesh.li...@gmail.com > Signed-off-by: Bhupesh Sharma <bhupesh.sha...@linaro.org> > --- > Documentation/devicetree/bindings/crypto/qcom-qce.txt | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.txt > b/Documentation/devicetree/bindings/crypto/qcom-qce.txt > index 07ee1b12000b..217b37dbd58a 100644 > --- a/Documentation/devicetree/bindings/crypto/qcom-qce.txt > +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.txt > @@ -2,7 +2,11 @@ Qualcomm crypto engine driver > > Required properties: > > -- compatible : should be "qcom,crypto-v5.1" > +- compatible : Supported versions are: > + - "qcom,crypto-v5.1", for ipq6018 > + - "qcom,crypto-v5.4", for sdm845, sm8150
2 SoCs sharing 1 version doesn't convince me on using version numbers. Having 4 versions for 5 SoCs further convinces me you should stick with SoC specific compatibles as *everyone* else does (including most QCom bindings). > + - "qcom,crypto-v5.5", for sm8250 > + - "qcom,crypto-v5.6", for sm8350 > - reg : specifies base physical address and size of the registers map > - clocks : phandle to clock-controller plus clock-specifier pair > - clock-names : "iface" clocks register interface > -- > 2.29.2 >
