On Thu, Mar 18, 2021 at 01:38:50PM +0100, Bjarni Jonasson wrote: > -static int vsc8584_config_init(struct phy_device *phydev) > +static int vsc8584_config_host_serdes(struct phy_device *phydev) > { > - struct vsc8531_private *vsc8531 = phydev->priv; > - int ret, i; > + int ret; > u16 val; > + struct vsc8531_private *vsc8531 = phydev->priv;
Reverse christmass tree. > +static int vsc8574_config_host_serdes(struct phy_device *phydev) > +{ > + int ret; > + u16 val; > + struct vsc8531_private *vsc8531 = phydev->priv; Here as well Andrew