>-----Original Message----- >From: Mika Penttilä [mailto:[EMAIL PROTECTED] >Sent: Wednesday, January 16, 2008 12:14 AM >To: Pallipadi, Venkatesh >Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; >[EMAIL PROTECTED]; [EMAIL PROTECTED]; >[EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; >[EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; >[EMAIL PROTECTED]; Barnes, Jesse; [EMAIL PROTECTED]; >linux-kernel@vger.kernel.org; Siddha, Suresh B >Subject: Re: [patch 2/4] x86: PAT followup - Remove >KERNPG_TABLE from pte entry > >[EMAIL PROTECTED] kirjoitti: >> KERNPG_TABLE was a bug in earlier patch. Remove it from pte. >> pte_val() check is redundant as this routine is called >immediately after a >> ptepage is allocated afresh. >> >> Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]> >> Signed-off-by: Suresh Siddha <[EMAIL PROTECTED]> >> >> Index: linux-2.6.git/arch/x86/mm/init_64.c >> =================================================================== >> --- linux-2.6.git.orig/arch/x86/mm/init_64.c 2008-01-15 >11:02:23.000000000 -0800 >> +++ linux-2.6.git/arch/x86/mm/init_64.c 2008-01-15 >11:06:37.000000000 -0800 >> @@ -541,9 +541,6 @@ >> if (address >= end) >> break; >> >> - if (pte_val(*pte)) >> - continue; >> - >> /* Nothing to map. Map the null page */ >> if (!(address & (~PAGE_MASK)) && >> (address + PAGE_SIZE <= end) && >> @@ -561,9 +558,9 @@ >> } >> >> if (exec) >> - entry = >_PAGE_NX|_KERNPG_TABLE|_PAGE_GLOBAL|address; >> + entry = _PAGE_NX|_PAGE_GLOBAL|address; >> else >> - entry = _KERNPG_TABLE|_PAGE_GLOBAL|address; >> + entry = _PAGE_GLOBAL|address; >> entry &= __supported_pte_mask; >> set_pte(pte, __pte(entry)); >> } >> >> > >Hmm then what's the point of mapping not present 4k pages for >valid mem >here? >
My bad... Thanks for the catch. I had to replace KERNPG_TABLE by PAGE_KERNEL here. Thanks, Venki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
