On Fri, Mar 19, 2021 at 2:31 PM Ulf Hansson <[email protected]> wrote:
>
> On Thu, 18 Mar 2021 at 19:15, Rafael J. Wysocki <[email protected]> wrote:
> >
> > From: "Rafael J. Wysocki" <[email protected]>
> >
> > Revert commit 44cc89f76464 ("PM: runtime: Update device status
> > before letting suppliers suspend") that introduced a race condition
> > into __rpm_callback() which allowed a concurrent rpm_resume() to
> > run and resume the device prematurely after its status had been
> > changed to RPM_SUSPENDED by __rpm_callback().
>
> Huh, the code path is not entirely easy to follow. :-)
>
> Did you find this by code inspection or did you get an error report?
There was a bug report that caused me to look at the code once again.
> > Fixes: 44cc89f76464 ("PM: runtime: Update device status before letting
> > suppliers suspend")
> > Link:
> > https://lore.kernel.org/linux-pm/[email protected]/
> > Reported by: Adrian Hunter <[email protected]>
> > Cc: 4.10+ <[email protected]> # 4.10+
> > Signed-off-by: Rafael J. Wysocki <[email protected]>
>
> Reviewed-by: Ulf Hansson <[email protected]>
Thanks!
