The framework already checks for us if V4L2_CTRL_WHICH_DEF_VAL is
written.

Cc: Mike Isely <is...@pobox.com>
Signed-off-by: Ricardo Ribalda <riba...@chromium.org>
Reviewed-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>
---
 drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c 
b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c
index 9657c1883311..c04ab7258d64 100644
--- a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c
+++ b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c
@@ -640,10 +640,6 @@ static int pvr2_s_ext_ctrls(struct file *file, void *priv,
        unsigned int idx;
        int ret;
 
-       /* Default value cannot be changed */
-       if (ctls->which == V4L2_CTRL_WHICH_DEF_VAL)
-               return -EINVAL;
-
        ret = 0;
        for (idx = 0; idx < ctls->count; idx++) {
                ctrl = ctls->controls + idx;
-- 
2.31.0.rc2.261.g7f71774620-goog

Reply via email to