On Thu, Mar 18, 2021 at 10:55:51AM -0700, Linus Torvalds wrote: > On Thu, Mar 18, 2021 at 10:49 AM Leon Romanovsky <l...@kernel.org> wrote: > > > > No, I opened patch and added the note manually, so it is definitely my VIM. > > Most likely this part of my .vimrc caused it. > > Ok, that would do it. > > Yeah, whitespace is easy to "fix" at patch application time, but it > really is meaningful and you never should change whitespace for > patches. > > Maybe you can limit your rules to just particular file types > (although, honestly, I think it's bad for headers and C files too when > it then causes entirely irrelevant and independent changes - you only > want your own _new_ edits to be whitespace-clean, not fix other random > issues). > > Better yet, maybe not "fix whitespace" at all, but have some code > coloring logic that just points out bad whitespace? I use "git diff" > myself, with colorization being default for tty operations: > > [color] > ui=auto > > so that then "git diff" will show you your (new) evil whitespace > errors when you review your changes, but won't complain about existing > whitespace issues..
Yeah, my color.ui is "always", so I will simply remove the problematic line from VIM and won't change whitespaces at all. Thanks > > Linus
