On Mon, Mar 22, 2021 at 12:44:34PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <a...@arndb.de>
>
> Building with 'make W=1' shows a harmless warning for pscsi:
>
> drivers/target/target_core_pscsi.c: In function 'pscsi_complete_cmd':
> drivers/target/target_core_pscsi.c:624:33: error: suggest braces around empty
> body in an 'if' statement [-Werror=empty-body]
> 624 | ; /* XXX:
> TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE */
> | ^
>
> Rework the coding style as suggested by gcc to avoid the warning.
I would much, much prefer to drop the bogus warning;
if (foo)
; /* comment */
is a fairly usual and absolutely sensible style. The warning on hte
other hand is completely stupid.
