On 3/23/21 8:04 AM, Mark Rutland wrote:
> On Tue, Mar 23, 2021 at 07:46:10AM -0500, Madhavan T. Venkataraman wrote:
>> On 3/23/21 5:42 AM, Mark Rutland wrote:
>>> On Mon, Mar 15, 2021 at 11:57:56AM -0500, madve...@linux.microsoft.com
>>> wrote:
>>>> From: "Madhavan T. Venkataraman" <madve...@linux.microsoft.com>
>>>>
>>>> EL1 exceptions can happen on any instruction including instructions in
>>>> the frame pointer prolog or epilog. Depending on where exactly they happen,
>>>> they could render the stack trace unreliable.
>>>>
>>>> If an EL1 exception frame is found on the stack, mark the stack trace as
>>>> unreliable.
>>>>
>>>> Now, the EL1 exception frame is not at any well-known offset on the stack.
>>>> It can be anywhere on the stack. In order to properly detect an EL1
>>>> exception frame the following checks must be done:
>>>>
>>>> - The frame type must be EL1_FRAME.
>>>>
>>>> - When the register state is saved in the EL1 pt_regs, the frame
>>>> pointer x29 is saved in pt_regs->regs[29] and the return PC
>>>> is saved in pt_regs->pc. These must match with the current
>>>> frame.
>>>
>>> Before you can do this, you need to reliably identify that you have a
>>> pt_regs on the stack, but this patch uses a heuristic, which is not
>>> reliable.
>>>
>>> However, instead you can identify whether you're trying to unwind
>>> through one of the EL1 entry functions, which tells you the same thing
>>> without even having to look at the pt_regs.
>>>
>>> We can do that based on the entry functions all being in .entry.text,
>>> which we could further sub-divide to split the EL0 and EL1 entry
>>> functions.
>>
>> Yes. I will check the entry functions. But I still think that we should
>> not rely on just one check. The additional checks will make it robust.
>> So, I suggest that the return address be checked first. If that passes,
>> then we can be reasonably sure that there are pt_regs. Then, check
>> the other things in pt_regs.
>
> What do you think this will catch?
>
I am not sure that I have an exact example to mention here. But I will attempt
one. Let us say that a task has called arch_stack_walk() in the recent past.
The unwinder may have copied a stack frame onto some location in the stack
with one of the return addresses we check. Let us assume that there is some
stack corruption that makes a frame pointer point to that exact record. Now,
we will get a match on the return address on the next unwind.
Pardon me if the example is somewhat crude. My point is that it is highly
unlikely
but not impossible for the return address to be on the stack and for the
unwinder to
get an unfortunate match.
> The only way to correctly identify whether or not we have a pt_regs is
> to check whether we're in specific portions of the EL1 entry assembly
> where the regs exist. However, as any EL1<->EL1 transition cannot be
> safely unwound, we'd mark any trace going through the EL1 entry assembly
> as unreliable.
>
> Given that, I don't think it's useful to check the regs, and I'd prefer
> to avoid the subtlteties involved in attempting to do so.
>
I agree that the return address check is a good check. I would like to add
extra checks to be absolutely sure.
> [...]
>
>>>> +static void check_if_reliable(unsigned long fp, struct stackframe *frame,
>>>> + struct stack_info *info)
>>>> +{
>>>> + struct pt_regs *regs;
>>>> + unsigned long regs_start, regs_end;
>>>> +
>>>> + /*
>>>> + * If the stack trace has already been marked unreliable, just
>>>> + * return.
>>>> + */
>>>> + if (!frame->reliable)
>>>> + return;
>>>> +
>>>> + /*
>>>> + * Assume that this is an intermediate marker frame inside a pt_regs
>>>> + * structure created on the stack and get the pt_regs pointer. Other
>>>> + * checks will be done below to make sure that this is a marker
>>>> + * frame.
>>>> + */
>>>
>>> Sorry, but NAK to this approach specifically. This isn't reliable (since
>>> it can be influenced by arbitrary data on the stack), and it's far more
>>> complicated than identifying the entry functions specifically.
>>
>> As I mentioned above, I agree that we should check the return address. But
>> just as a precaution, I think we should double check the pt_regs.
>>
>> Is that OK with you? It does not take away anything or increase the risk in
>> anyway. I think it makes it more robust.
>
> As above, I think that the work necessary to correctly access the regs
> means that it's not helpful to check the regs themselves. If you have
> something in mind where checking the regs is helpful I'm happy to
> consider that, but my general preference would be to stay away from the
> regs for now.
>
I have mentioned a possibility above. Please take a look and let me know.
Thanks.
Madhavan
