Re: [PATCH v2 1/5] mm/migrate.c: remove unnecessary VM_BUG_ON_PAGE on putback_movable_page()

[David Hildenbrand]

On 23.03.21 14:54, Miaohe Lin wrote:

The !PageLocked() check is implicitly done in PageMovable(). Remove this
explicit one.

Signed-off-by: Miaohe Lin <linmia...@huawei.com>
---
  mm/migrate.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/mm/migrate.c b/mm/migrate.c
index 47df0df8f21a..facec65c7374 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -145,7 +145,6 @@ void putback_movable_page(struct page *page)
  {
        struct address_space *mapping;

- VM_BUG_ON_PAGE(!PageLocked(page), page);

        VM_BUG_ON_PAGE(!PageMovable(page), page);
        VM_BUG_ON_PAGE(!PageIsolated(page), page);

Reviewed-by: David Hildenbrand <da...@redhat.com>

--
Thanks,

David / dhildenb