Hi Ingo,
On 2021/3/23 19:23, Ingo Molnar wrote:
>
> * Shaokun Zhang <zhangshao...@hisilicon.com> wrote:
>
>> Commit 0cd39f4600ed ("locking/seqlock, headers: Untangle the spaghetti
>> monster")
>> introduces 'struct ww_acquire_ctx' again, remove the repeated declaration.
>>
>> Cc: Peter Zijlstra <pet...@infradead.org>
>> Cc: Ingo Molnar <mi...@redhat.com>
>> Cc: Will Deacon <w...@kernel.org>
>> Cc: Waiman Long <long...@redhat.com>
>> Cc: Boqun Feng <boqun.f...@gmail.com>
>> Signed-off-by: Shaokun Zhang <zhangshao...@hisilicon.com>
>> ---
>> include/linux/mutex.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/include/linux/mutex.h b/include/linux/mutex.h
>> index 0cd631a19727..d80c0e22c822 100644
>> --- a/include/linux/mutex.h
>> +++ b/include/linux/mutex.h
>> @@ -20,8 +20,6 @@
>> #include <linux/osq_lock.h>
>> #include <linux/debug_locks.h>
>>
>> -struct ww_acquire_ctx;
>> -
>> /*
>> * Simple, straightforward mutexes with strict semantics:
>> *
>
> Please also group the pre-declarations together, that's the canonical
> pattern we use in headers.
Ok,
>
> I.e. have something like this at the top:
>
Got it, I will do it in next version.
Thanks,
Shaokun
> struct ww_class;
> struct ww_acquire_ctx;
>
> Thanks,
>
> Ingo
> .
>
