Hi Masahiro,
On Wed, Mar 24, 2021 at 10:57 AM Masahiro Yamada <[email protected]> wrote:
>
> The section "19) Editor modelines and other cruft" in
> Documentation/process/coding-style.rst clearly says,
> "Do not include any of these in source files."
>
> I recently receive a patch to explicitly add a new one.
>
> Let's do treewide cleanups, otherwise some people follow the existing
> code and attempt to upstream their favoriate editor setups.
>
> It is even nicer if scripts/checkpatch.pl can check it.
>
> If we like to impose coding style in an editor-independent manner,
> I think editorconfig (patch [1]) is a saner solution.
>
> [1] https://lore.kernel.org/lkml/[email protected]/
>
> Signed-off-by: Masahiro Yamada <[email protected]>
+1 It is great to get rid of those.
For auxdisplay:
Reviewed-by: Miguel Ojeda <[email protected]>
For the rest, I did a quick visual inspection and didn't see anything wrong.
Cheers,
Miguel
