Hi Laurent, Thank you so much for the review.
> -----Original Message----- > From: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Sent: Wednesday, March 24, 2021 8:38 AM > To: Manish Narani <mnar...@xilinx.com> > Cc: kis...@ti.com; vk...@kernel.org; Michal Simek <mich...@xilinx.com>; > linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; git > <g...@xilinx.com> > Subject: Re: [PATCH v3] phy: zynqmp: Handle the clock enable/disable > properly > > Hi Manish, > > Thank you for the patch. > > On Tue, Mar 23, 2021 at 07:49:47PM +0530, Manish Narani wrote: > > The current driver is not handling the clock enable/disable operations > > properly. The clocks need to be handled correctly by enabling or > > disabling at appropriate places. This patch adds code to handle the > > same. > > > > Signed-off-by: Manish Narani <manish.nar...@xilinx.com> > > This looks good to me. > > Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > > However, it would be really nice to make clock handling dynamic, to only > enable clocks that are needed by active PHYs. Keeping them enabled at > all times will waste power. It can be done on top of this patch. Is it > something you could work on ? Sure. I'll plan to work on that. I have sent v4 for this with Michal's input. Thanks, Manish
