Hi, On 03/23, qianli zhao wrote: > > Hi,Oleg > > > You certainly don't understand me :/ > > > Please read my email you quoted below. I didn't mean the current logic. > > I meant the logic after your patch which moves atomic_dec_and_test() and > > panic() before exit_signals(). > > Sorry, I think I see what you mean now. > > You mean that after apply my patch,SIGNAL_GROUP_EXIT no longer needs > to be tested or avoid zap_pid_ns_processes()->BUG(). > Yes,your consideration is correct.
OK, great > But,my patch has another purpose,protect some key variables(such > as:task->mm,task->nsproxy,etc) to recover init coredump from > fulldump,if sub-threads finish do_exit(), Yes I know. But the purpose of this SIGNAL_GROUP_EXIT check is not clear and not documented. That is why I said it should be documented at least in the changelog. Oleg.
