On Tue, Mar 23, 2021 at 2:10 PM Arnd Bergmann <a...@kernel.org> wrote:
> From: Arnd Bergmann <a...@arndb.de>
>
> Building with 'make W=1' shows an array overflow:
>
> drivers/pinctrl/pinctrl-microchip-sgpio.c: In function
> 'microchip_sgpio_irq_settype':
> drivers/pinctrl/pinctrl-microchip-sgpio.c:154:39: error: array subscript 10
> is above array bounds of 'const u8[10]' {aka 'const unsigned char[10]'}
> [-Werror=array-bounds]
> 154 | u32 regoff = priv->properties->regoff[rno] + off;
> | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
> drivers/pinctrl/pinctrl-microchip-sgpio.c:55:5: note: while referencing
> 'regoff'
> 55 | u8 regoff[MAXREG];
> | ^~~~~~
>
> It's not clear to me what was meant here, my best guess is that the
> offset should have been applied to the third argument instead of the
> second.
>
> Fixes: be2dc859abd4 ("pinctrl: pinctrl-microchip-sgpio: Add irq support (for
> sparx5)")
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
Patch applied.
Yours,
Linus Walleij
