On Thu, Mar 25, 2021 at 3:34 PM Eric Dumazet <eric.duma...@gmail.com> wrote:
> On 3/25/21 11:31 AM, Dmitry Vyukov wrote:
> > netdev_unregister_timeout_secs=0 can lead to printing the
> > "waiting for dev to become free" message every jiffy.
> > This is too frequent and unnecessary.
> > Set the min value to 1 second.
> >
> > Signed-off-by: Dmitry Vyukov <dvyu...@google.com>
> > Suggested-by: Eric Dumazet <eduma...@google.com>
> > Fixes: 5aa3afe107d9 ("net: make unregister netdev warning timeout
> > configurable")
> > Cc: net...@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > ---
>
> Please respin your patch, and fix the merge issue [1]
Is net-next rebuilt and rebased? Do I send v4 of the whole change?
I cannot base it on net-next now, because net-next already includes
most of it... so what should I use as base then?
> For networking patches it is customary to tell if its for net or net-next
> tree.
>
> [1]
> diff --git a/net/core/dev.c b/net/core/dev.c
> index
> 4bb6dcdbed8b856c03dc4af8b7fafe08984e803f..7bb00b8b86c6494c033cf57460f96ff3adebe081
> 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -10431,7 +10431,7 @@ static void netdev_wait_allrefs(struct net_device
> *dev)
>
> refcnt = netdev_refcnt_read(dev);
>
> - if (refcnt &&
> + if (refcnt != 1 &&
> time_after(jiffies, warning_time +
> netdev_unregister_timeout_secs * HZ)) {
> pr_emerg("unregister_netdevice: waiting for %s to
> become free. Usage count = %d\n",
