Re: [PATCH] x86: Use v8086_mode helper, trivial unification

[H. Peter Anvin]

Harvey Harrison wrote:

What do you think of:

/*
 * (unsigned long)regs looks strange, but it's correct for x86_32.  x86_32 CPUs
 * don't save the ss and esp registers if the CPU is already in kernel mode
 * when it traps.  So &regs happens to be esp.  Valid only for kernel-mode
 * pt_regs.
 */
static inline unsigned long stack_pointer(struct pt_regs *regs)
{
#ifdef CONFIG_X86_32
        return (unsigned long)regs;
#else
        return regs->sp;
#endif
}


Please highlight the last sentence better.  That's a user restriction 
and a highly important one.

        -hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/