Hi Kishon,

Thank you for sending the series over!

A few small nitpick, so feel free to ignore it.

[...]
> +     ret = irq_domain_alloc_irqs_parent(domain, virq, 1, &parent_fwspec);
> +     if (ret < 0) {
> +             pr_err("Failed to allocate parent irq %u: %d\n",
> +                    parent_fwspec.param[0], ret);
> +             return ret;
[...]

Use "IRQ" in the message above.

Also, the error messages with both starting with upper- and lower- case
letter, not sure if this is because of dev_err() vs pr_err(), but if
there is no significance between these two methods, then it might be
nice to keep the style consistent.

Krzysztof

Reply via email to