> unsigned long end; > - struct mm_struct *mm = current->mm; > + int error, unmapped_error; > struct vm_area_struct *vma; > - int unmapped_error = 0; > - int error = -EINVAL; > + struct mm_struct *mm; > > + error = -EINVAL;
I think you may have misunderstood my last comment. These are OK: struct mm_struct *mm = current->mm; int unmapped_error = 0; int error = -EINVAL; This is not so good: int error, unmapped_error; This is the worst: int error = -EINVAL, unmapped_error = 0; So I think the original code is fine as it is. Othewise patch looks OK now. Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/