Hi, > -----Original Message----- > From: Pierre-Louis Bossart <[email protected]> > Sent: vendredi 26 mars 2021 22:59 > To: [email protected] > Cc: [email protected]; [email protected]; [email protected]; Pierre- > Louis Bossart <[email protected]>; Arnaud POULIQUEN > <[email protected]>; Liam Girdwood <[email protected]>; > Jaroslav Kysela <[email protected]>; Takashi Iwai <[email protected]> > Subject: [PATCH 09/17] ASoC: sti: uniperif: align function prototypes > > cppcheck warning: > > sound/soc/sti/uniperif_player.c:1049:24: style:inconclusive: Function > 'uni_player_init' argument 2 names different: declaration 'uni_player' > definition 'player'. [funcArgNamesDifferent] > struct uniperif *player) > ^ > sound/soc/sti/uniperif.h:1375:24: note: Function 'uni_player_init' > argument 2 names different: declaration 'uni_player' definition 'player'. > struct uniperif *uni_player); > ^ > sound/soc/sti/uniperif_player.c:1049:24: note: Function 'uni_player_init' > argument 2 names different: declaration 'uni_player' > definition 'player'. > struct uniperif *player) > ^ > sound/soc/sti/uniperif_reader.c:411:24: style:inconclusive: Function > 'uni_reader_init' argument 2 names different: declaration 'uni_reader' > definition 'reader'. [funcArgNamesDifferent] > struct uniperif *reader) > ^ > sound/soc/sti/uniperif.h:1380:24: note: Function 'uni_reader_init' > argument 2 names different: declaration 'uni_reader' definition 'reader'. > struct uniperif *uni_reader); > ^ > sound/soc/sti/uniperif_reader.c:411:24: note: Function 'uni_reader_init' > argument 2 names different: declaration 'uni_reader' > definition 'reader'. > struct uniperif *reader) > ^ > > Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Arnaud Pouliquen <[email protected]> Thanks Arnaud > --- > sound/soc/sti/uniperif.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h index > a16adeb7c1e9..2a5de328501c 100644 > --- a/sound/soc/sti/uniperif.h > +++ b/sound/soc/sti/uniperif.h > @@ -1372,12 +1372,12 @@ static __maybe_unused const struct > snd_pcm_hardware uni_tdm_hw = { > > /* uniperiph player*/ > int uni_player_init(struct platform_device *pdev, > - struct uniperif *uni_player); > + struct uniperif *player); > int uni_player_resume(struct uniperif *player); > > /* uniperiph reader */ > int uni_reader_init(struct platform_device *pdev, > - struct uniperif *uni_reader); > + struct uniperif *reader); > > /* common */ > int sti_uniperiph_dai_set_fmt(struct snd_soc_dai *dai, > -- > 2.25.1
