At 18.36 18/01/2008, Arjan van de Ven wrote:
>The Intel Open Source Technology Center is pleased to announce the
>release of version 0.1 of LatencyTOP, a tool for developers to visualize
>system latencies.
>
>http://www.latencytop.org
>
[...snip...]
>
>The most basic annotation looks like this (in the patches more complex
>versions can be seen):
>
> asmlinkage long sys_sync(void)
> {
>+ struct latency_entry reason;
>+ set_latency_reason("sync system call", &reason);
> do_sync(1);
>+ restore_latency_reason(&reason);
>+
> return 0;
> }
>
I really like this patch :-)! Just a little note, why don't make
the parameter 'char *reason' as simple integer (reason_t)?
Making it as integer will automatically drop the strncmp()
and speeding up all the things. Could be also interesting to
define _externally_ the mapping of the reason so the
userspace tool could handle it easily.
Roberto Fichera.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
