Rusty Russell wrote:
On Saturday 19 January 2008 07:41:41 Jeff Garzik wrote:
You should be using irq_handler_t for all these.
Well, these are your drivers, but for mine I dislike the obfuscation.
It's not like you can declare the function itself to be an irq_handler_t, so
it's a strange turd to drop in a driver.
The others need to be irq_handler_t because that's the precise type
that's being used in each particularly situation. Each time the code
re-creates that definition creates a problem for future irq handler
changes of any type, really.
As I noted, I've fixed all this crap already, and read through each one
of those drivers.
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/