On Friday, January 18, 2008 10:12 am Andi Kleen wrote: > I looked back then when I had bisected it down and I admit I didn't spot > the problem from source review. I think it came from the reordering so > blacklisting AMD alone wouldn't have helped. Might have been some > subtle race (e.g. long ago we had such races in the MTRR code > triggered by the first HT CPUs) > > Anyways I just test booted latest git-x86 with your patches included on > the QC system and it booted now. However it has both more RAM and newer > CPUs (the original ones were pre-production, that is why I also didn't send > you logs[1] ..) then when I tested originally. So this means either the > problem was somewhere else or the different configuration hides it. > > I guess you will hear about it if it's still broken on other machines. > > Currently it looks good. > > I think it should be enabled on AMD too though. If the reordering breaks > it then blacklisting won't help anyways. > > -Andi > > [1] but I checked the known errata and there was nothing related to MTRR.
Ah, ok, that explains your reticence earlier. Thanks for testing again, I guess the patch is good to go. Jesse -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/